publish-all.js ➔ publishNext - Code Metrics - Inspection of "refactoring: meta + UT" - AdFabConnect/abejs - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 9899df...273a12 )

unknown

created 2016-10-05 14:37 UTC

publish-all.js ➔ publishNext B

↳ Parent: src/cli/process/publish-all.js

Complexity

Conditions	5
Paths	3

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	5
c	1
b	0
f	0
nc	3
dl	0
loc	59
rs	8.7117
nop	4

3 Functions

Rating	Name	Size	Complexity
A	publish-all.js ➔ ... ➔ p.catch	4	1
A	publish-all.js ➔ ... ➔ p.then	3	1
B	publish-all.js ➔ ... ➔ ???	37	2

How to fix Long Method

import clc from 'cli-color'
import path from 'path'
import fse from 'fs-extra'

// ./node_modules/.bin/babel-node src/cli/process/publish-all.js ABE_WEBSITE=/path/to/website
// ./node_modules/.bin/babel-node src/cli/process/publish-all.js FILEPATH=/path/to/website/path/to/file.html ABE_WEBSITE=/path/to/website
var pConfig = {}
Array.prototype.forEach.call(process.argv, (item) => {
  if (item.indexOf('=') > -1) {
    var ar = item.split('=')
    pConfig[ar[0]] = ar[1]
  }
})

if(typeof pConfig.ABE_PATH === 'undefined' || pConfig.ABE_PATH === null) {
  pConfig.ABE_PATH = ''
}

console.log(clc.green('start publish all') + ' path ' + pConfig.ABE_PATH)


function msToTime(duration) {
  var milliseconds = parseInt((duration%1000)/100)
        , seconds = parseInt((duration/1000)%60)
        , minutes = parseInt((duration/(1000*60))%60)
        , hours = parseInt((duration/(1000*60*60))%24)

  hours = (hours < 10) ? '0' + hours : hours
  minutes = (minutes < 10) ? '0' + minutes : minutes
  seconds = (seconds < 10) ? '0' + seconds : seconds

  return hours + ':' + minutes + ':' + seconds + '.' + milliseconds
}

function publishNext(published, tt, cb, i = 0) {
  var currentDateStart = new Date()
  var pub = published.shift()
  if(typeof pub !== 'undefined' && pub !== null) {
    
    var json = FileParser.getJson(pub.path)
    if(typeof json.abe_meta !== 'undefined' && json.abe_meta !== null) {
      i++

      var p = new Promise((resolve, reject) => {

        try {
          
          cmsOperations.save.save(
            pub.path,
            json.abe_meta.template,
            null,
            '',
            'publish',
            null,
            'publish',
            true)
            .then(() => {
              var d = new Date(new Date().getTime() - currentDateStart.getTime())
              var total = new Date(new Date().getTime() - dateStart.getTime())
              // logsPub += i + ' [' + d + 'sec] > start publishing ' + pub.path .replace(config.root, '') + ' < ' + pub.path
              console.log(clc.green(i) + '/' + tt + ' - (' + clc.green(msToTime(d)) + '/' + msToTime(total) + ')')

              console.log(clc.bgWhite(clc.black(pub.path.replace(config.root, '').replace(config.data.url, '')))
                + ' (' + clc.cyan(json.abe_meta.template) + ')')
              resolve()
            }).catch(function(e) {
              var d = new Date(new Date().getTime() - currentDateStart.getTime())
              var total = new Date(new Date().getTime() - dateStart.getTime())
              console.log(clc.red(i) + '/' + tt + ' - (' + clc.red(msToTime(d)) + '/' + msToTime(total) + ')')

              publishErrors.push({
                msg: e + ''
                , json:json
              })
              console.log(clc.red(e))
              console.log('publish-all', 'ERROR on ' + pub.path.replace(config.root, '').replace(config.data.url, ''))
              resolve()
            })
        } catch(e) {
          console.log(clc.red('cannot save') + ' ' + pub.path)
          resolve()
        }
      })
    }

    p.then(function () {

      publishNext(published, tt, cb, i++)
    })
    .catch(function () {
      publishNext(published, tt, cb, i++)
      console.log('error', clc.red(e))

    })
  }else {
    cb(i)
  }
}

var publishErrors = []
var dateStart = new Date()
// var logsPub = ""
if(typeof pConfig.ABE_WEBSITE !== 'undefined' && pConfig.ABE_WEBSITE !== null) {
  var config = require('../../cli').config
  if(pConfig.ABE_WEBSITE) config.set({root: pConfig.ABE_WEBSITE.replace(/\/$/, '') + '/'})
if (a > 0)
    b = 42;
  try {

    // require controller to instanciate hooks
    var controllers = require('../../server/controllers')
    var FileParser = require('../../cli').FileParser
    var fileUtils = require('../../cli').fileUtils
    var folderUtils = require('../../cli').folderUtils
    var cmsOperations = require('../../cli').cmsOperations
    var Manager = require('../../cli').Manager

    Manager.instance.init()
      .then(() => {
        var i = 0


        var files = Manager.instance.getList()

        // var result = []
        var published = []
        var folderToParse = path.join(config.root, config.data.url, pConfig.ABE_PATH)
        Array.prototype.forEach.call(files, (file) => {
          if (typeof file.publish !== 'undefined' && file.publish !== null && file.path.indexOf(folderToParse) > -1) {
            published.push(file)
          }
        })

        console.log('Found ' + clc.green(published.length) + ' to republish')


        dateStart = new Date()
        publishNext(published, published.length, function (i) {
          console.log('total ' + clc.green(i) + ' files')

          if (publishErrors.length > 0) {
            var errorPath = path.join(config.root, 'abe-publish-all.' + dateStart.getTime() + '.log')
            console.log('Errors ' + clc.red(publishErrors.length) + ' see ' + errorPath + ' for more info')
            fse.writeJsonSync(errorPath, publishErrors, {
              space: 2,
              encoding: 'utf-8'
            })
          }
          dateStart = (Math.round((new Date().getTime() - dateStart.getTime()) / 1000 / 60 * 100)) / 100
          console.log('publish process finished in ' + clc.green(dateStart) + 'm')
          process.exit(0)

        })
      })
      .catch((e) => {
        console.log('publish-all', e)

      })

  } catch(e) {
    console.log('publish-all', e)
  }

}else {
  console.log('ABE_WEBSITE is not defined use node process.js ABE_WEBSITE=/pat/to/website')
  process.exit(0)

}

1			import clc from 'cli-color'
2			import path from 'path'
3			import fse from 'fs-extra'
4
5			// ./node_modules/.bin/babel-node src/cli/process/publish-all.js ABE_WEBSITE=/path/to/website
6			// ./node_modules/.bin/babel-node src/cli/process/publish-all.js FILEPATH=/path/to/website/path/to/file.html ABE_WEBSITE=/path/to/website
7			var pConfig = {}
8			Array.prototype.forEach.call(process.argv, (item) => {
9			if (item.indexOf('=') > -1) {
10			var ar = item.split('=')
11			pConfig[ar[0]] = ar[1]
12			}
13			})
14
15			if(typeof pConfig.ABE_PATH === 'undefined' \|\| pConfig.ABE_PATH === null) {
16			pConfig.ABE_PATH = ''
17			}
18
19			console.log(clc.green('start publish all') + ' path ' + pConfig.ABE_PATH)
			0 ignored issues – show Debugging Code introduced 2016-09-27 10:32 UTC by Report Bug Copy Issue Report `console.log` looks like debug code. Are you sure you do not want to remove it? Loading history...
20
21			function msToTime(duration) {
22			var milliseconds = parseInt((duration%1000)/100)
23			, seconds = parseInt((duration/1000)%60)
24			, minutes = parseInt((duration/(1000*60))%60)
25			, hours = parseInt((duration/(10006060))%24)
26
27			hours = (hours < 10) ? '0' + hours : hours
28			minutes = (minutes < 10) ? '0' + minutes : minutes
29			seconds = (seconds < 10) ? '0' + seconds : seconds
30
31			return hours + ':' + minutes + ':' + seconds + '.' + milliseconds
32			}
33
34			function publishNext(published, tt, cb, i = 0) {
35			var currentDateStart = new Date()
36			var pub = published.shift()
37			if(typeof pub !== 'undefined' && pub !== null) {
38
39			var json = FileParser.getJson(pub.path)
40			if(typeof json.abe_meta !== 'undefined' && json.abe_meta !== null) {
41			i++
42
43			var p = new Promise((resolve, reject) => {
			0 ignored issues – show Unused Code introduced 2016-09-27 10:32 UTC by Report Bug Copy Issue Report The parameter `reject` is not used and could be removed. This check looks for parameters in functions that are not used in the function body and are not followed by other parameters which are used inside the function. Loading history...
44			try {
45
46			cmsOperations.save.save(
47			pub.path,
48			json.abe_meta.template,
49			null,
50			'',
51			'publish',
52			null,
53			'publish',
54			true)
55			.then(() => {
56			var d = new Date(new Date().getTime() - currentDateStart.getTime())
57			var total = new Date(new Date().getTime() - dateStart.getTime())
58			// logsPub += i + ' [' + d + 'sec] > start publishing ' + pub.path .replace(config.root, '') + ' < ' + pub.path
59			console.log(clc.green(i) + '/' + tt + ' - (' + clc.green(msToTime(d)) + '/' + msToTime(total) + ')')
			0 ignored issues – show Debugging Code introduced 2016-09-27 10:32 UTC by Report Bug Copy Issue Report `console.log` looks like debug code. Are you sure you do not want to remove it? Loading history...
60			console.log(clc.bgWhite(clc.black(pub.path.replace(config.root, '').replace(config.data.url, '')))
61			+ ' (' + clc.cyan(json.abe_meta.template) + ')')
62			resolve()
63			}).catch(function(e) {
64			var d = new Date(new Date().getTime() - currentDateStart.getTime())
65			var total = new Date(new Date().getTime() - dateStart.getTime())
66			console.log(clc.red(i) + '/' + tt + ' - (' + clc.red(msToTime(d)) + '/' + msToTime(total) + ')')
			0 ignored issues – show Debugging Code introduced 2016-09-27 10:32 UTC by Report Bug Copy Issue Report `console.log` looks like debug code. Are you sure you do not want to remove it? Loading history...
67			publishErrors.push({
68			msg: e + ''
69			, json:json
70			})
71			console.log(clc.red(e))
72			console.log('publish-all', 'ERROR on ' + pub.path.replace(config.root, '').replace(config.data.url, ''))
73			resolve()
74			})
75			} catch(e) {
76			console.log(clc.red('cannot save') + ' ' + pub.path)
77			resolve()
78			}
79			})
80			}
81
82			p.then(function () {
			0 ignored issues – show Bug introduced 2016-09-27 10:32 UTC by Report Bug Copy Issue Report The variable `p` does not seem to be initialized in case `typeof json.abe_meta !=... json.abe_meta !== null` on line `40` is `false`. Are you sure this can never be the case? Loading history...
83			publishNext(published, tt, cb, i++)
84			})
85			.catch(function () {
86			publishNext(published, tt, cb, i++)
87			console.log('error', clc.red(e))
			0 ignored issues – show Debugging Code introduced 2016-09-27 10:32 UTC by Report Bug Copy Issue Report `console.log` looks like debug code. Are you sure you do not want to remove it? Loading history... Bug introduced 2016-09-27 10:32 UTC by Report Bug Copy Issue Report The variable `e` seems to be never initialized. Loading history...
88			})
89			}else {
90			cb(i)
91			}
92			}
93
94			var publishErrors = []
95			var dateStart = new Date()
96			// var logsPub = ""
97			if(typeof pConfig.ABE_WEBSITE !== 'undefined' && pConfig.ABE_WEBSITE !== null) {
98			var config = require('../../cli').config
99			if(pConfig.ABE_WEBSITE) config.set({root: pConfig.ABE_WEBSITE.replace(/\/$/, '') + '/'})
			0 ignored issues – show Coding Style Best Practice introduced 2016-09-27 10:32 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
100			try {
101
102			// require controller to instanciate hooks
103			var controllers = require('../../server/controllers')
104			var FileParser = require('../../cli').FileParser
105			var fileUtils = require('../../cli').fileUtils
106			var folderUtils = require('../../cli').folderUtils
107			var cmsOperations = require('../../cli').cmsOperations
108			var Manager = require('../../cli').Manager
109
110			Manager.instance.init()
111			.then(() => {
112			var i = 0
			0 ignored issues – show Unused Code introduced 2016-09-27 10:32 UTC by Report Bug Copy Issue Report The variable `i` seems to be never used. Consider removing it. Loading history...
113
114			var files = Manager.instance.getList()
115
116			// var result = []
117			var published = []
118			var folderToParse = path.join(config.root, config.data.url, pConfig.ABE_PATH)
119			Array.prototype.forEach.call(files, (file) => {
120			if (typeof file.publish !== 'undefined' && file.publish !== null && file.path.indexOf(folderToParse) > -1) {
121			published.push(file)
122			}
123			})
124
125			console.log('Found ' + clc.green(published.length) + ' to republish')
			0 ignored issues – show Debugging Code introduced 2016-09-27 10:32 UTC by Report Bug Copy Issue Report `console.log` looks like debug code. Are you sure you do not want to remove it? Loading history...
126
127			dateStart = new Date()
128			publishNext(published, published.length, function (i) {
129			console.log('total ' + clc.green(i) + ' files')
			0 ignored issues – show Debugging Code introduced 2016-09-27 10:32 UTC by Report Bug Copy Issue Report `console.log` looks like debug code. Are you sure you do not want to remove it? Loading history...
130			if (publishErrors.length > 0) {
131			var errorPath = path.join(config.root, 'abe-publish-all.' + dateStart.getTime() + '.log')
132			console.log('Errors ' + clc.red(publishErrors.length) + ' see ' + errorPath + ' for more info')
133			fse.writeJsonSync(errorPath, publishErrors, {
134			space: 2,
135			encoding: 'utf-8'
136			})
137			}
138			dateStart = (Math.round((new Date().getTime() - dateStart.getTime()) / 1000 / 60 * 100)) / 100
139			console.log('publish process finished in ' + clc.green(dateStart) + 'm')
140			process.exit(0)
			0 ignored issues – show Compatibility Debugging Code Best Practice introduced 2016-09-27 10:32 UTC by Report Bug Copy Issue Report Use of `process.exit()` is discouraged as it will potentially stop the complete node.js application. Consider quitting gracefully instead by throwing an Error. Loading history...
141			})
142			})
143			.catch((e) => {
144			console.log('publish-all', e)
			0 ignored issues – show Debugging Code introduced 2016-09-27 10:32 UTC by Report Bug Copy Issue Report `console.log` looks like debug code. Are you sure you do not want to remove it? Loading history...
145			})
146
147			} catch(e) {
148			console.log('publish-all', e)
149			}
150
151			}else {
152			console.log('ABE_WEBSITE is not defined use node process.js ABE_WEBSITE=/pat/to/website')
153			process.exit(0)
			0 ignored issues – show Compatibility Debugging Code Best Practice introduced 2016-09-27 10:32 UTC by Report Bug Copy Issue Report Use of `process.exit()` is discouraged as it will potentially stop the complete node.js application. Consider quitting gracefully instead by throwing an Error. Loading history...
154			}

AdFabConnect / abejs

Push — master ( 9899df...273a12 )

publish-all.js ➔ publishNext B

Complexity

Size

Duplication

Importance

3 Functions

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like